pvary commented on code in PR #12979:
URL: https://github.com/apache/iceberg/pull/12979#discussion_r2115595974
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TableChange.java:
##########
@@ -76,7 +82,11 @@ private TableChange(
this.eqDeleteRecordCount += deleteFile.recordCount();
break;
default:
- throw new IllegalArgumentException("Unexpected delete file
content: " + deleteFile);
+ if (throwException) {
+ throw new IllegalArgumentException("Unexpected delete file
content: " + deleteFile);
+ } else {
+ LOG.warn("Unexpected delete file content:{}",
deleteFile.content());
+ }
Review Comment:
I think the likelihood of introducing a new content type is very low, and we
probably want to know about it as soon as possible, so exception is better than
"silently" logging a warning. If the caller wants to do it this way, it can
still catch the exception, and continue working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
