pvary commented on code in PR #12979:
URL: https://github.com/apache/iceberg/pull/12979#discussion_r2115600785
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerEvaluator.java:
##########
@@ -100,6 +100,22 @@ public Builder timeout(Duration newTimeout) {
return this;
}
+ public Integer dataFileCount() {
+ return dataFileCount;
+ }
+
+ public Long dataFileSizeInBytes() {
+ return dataFileSizeInBytes;
+ }
+
+ public Integer commitCount() {
+ return commitCount;
+ }
+
+ public Duration timeout() {
+ return timeout;
+ }
+
Review Comment:
Hmmm.. I'm not really happy with exposing internal stuff on a Builder?
Especially since this happens only for testing purposes. Could we just check
the configuration of the object created by the builder instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
