Guosmilesmile commented on code in PR #12979:
URL: https://github.com/apache/iceberg/pull/12979#discussion_r2114271560
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerEvaluator.java:
##########
@@ -100,6 +100,22 @@ public Builder timeout(Duration newTimeout) {
return this;
}
+ public Integer dataFileCount() {
+ return dataFileCount;
+ }
+
+ public Long dataFileSizeInBytes() {
+ return dataFileSizeInBytes;
+ }
+
+ public Integer commitCount() {
+ return commitCount;
+ }
+
+ public Duration timeout() {
+ return timeout;
+ }
+
Review Comment:
This part was added to perform parameter validation in unit tests, and since
`MaintenanceTaskBuilder` and `TriggerEvaluator` are not in the same package, it
is not possible to add `@VisibleForTesting`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
