liamzwbao commented on code in PR #13072:
URL: https://github.com/apache/iceberg/pull/13072#discussion_r2125232523
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -468,22 +467,7 @@ private boolean isReservedProperty(String prop) {
}
private static void validateTableSchemaAndPartition(CatalogTable ct1,
CatalogTable ct2) {
- TableSchema ts1 = ct1.getSchema();
- TableSchema ts2 = ct2.getSchema();
- boolean equalsPrimary = false;
-
- if (ts1.getPrimaryKey().isPresent() && ts2.getPrimaryKey().isPresent()) {
- equalsPrimary =
- Objects.equals(ts1.getPrimaryKey().get().getType(),
ts2.getPrimaryKey().get().getType())
- && Objects.equals(
- ts1.getPrimaryKey().get().getColumns(),
ts2.getPrimaryKey().get().getColumns());
- } else if (!ts1.getPrimaryKey().isPresent() &&
!ts2.getPrimaryKey().isPresent()) {
- equalsPrimary = true;
- }
-
- if (!(Objects.equals(ts1.getTableColumns(), ts2.getTableColumns())
- && Objects.equals(ts1.getWatermarkSpecs(), ts2.getWatermarkSpecs())
- && equalsPrimary)) {
Review Comment:
This part already covered by
[equals](https://github.com/apache/flink/blob/00dcccf8bc0f67e5180f6b179d8a63b27fb1fa1e/flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/Schema.java#L138-L155)
of Schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
