dttung2905 commented on PR #414: URL: https://github.com/apache/iceberg-go/pull/414#issuecomment-2910693026
> just a few comments but overall looks good to me so far. > > Is there any way we can set up an integration test to compare against other implementations? @zeroshade Thanks for the review. I have made some changes for the linting which should make the CI passes. Regarding the integration test, I think its a good idea. I'm working on something similar to `rest_integration_test.go` but for SQL catalog. Since this PR is getting substantially big to review, can I include the integration in the next PR ? wdyt ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
