zeroshade commented on code in PR #414:
URL: https://github.com/apache/iceberg-go/pull/414#discussion_r2130044887
##########
catalog/sql/sql_test.go:
##########
@@ -280,7 +280,8 @@ func (s *SqliteCatalogTestSuite)
TestCreationOneTableExists() {
_, err := sqldb.Exec(`CREATE TABLE "iceberg_tables" (
"catalog_name" VARCHAR NOT NULL,
"table_namespace" VARCHAR NOT NULL,
- "table_name" VARCHAR NOT NULL,
+ "table_name" VARCHAR NOT NULL,
+ "iceberg_type" VARCHAR,
Review Comment:
I'd have to look back at the JDBC impl, but should this also be NOT NULL?
possibly with a default of TABLE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
