dttung2905 commented on code in PR #414:
URL: https://github.com/apache/iceberg-go/pull/414#discussion_r2101167195


##########
catalog/sql/sql.go:
##########
@@ -133,8 +136,12 @@ type sqlIcebergTable struct {
        CatalogName              string `bun:",pk"`
        TableNamespace           string `bun:",pk"`
        TableName                string `bun:",pk"`
+       IcebergType              string // "TABLE" or "VIEW"
        MetadataLocation         sql.NullString
        PreviousMetadataLocation sql.NullString
+       ViewSQL                  sql.NullString    // Only populated for views
+       SchemaJSON               sql.NullString    // Only populated for views
+       Properties               map[string]string `bun:"type:jsonb"` // Only 
populated for views

Review Comment:
   My bad, I was refering to CreateViewRequest struct in this Swagger API 
https://petstore.swagger.io/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fapache%2Ficeberg%2Frefs%2Fheads%2Fmain%2Fopen-api%2Frest-catalog-open-api.yaml#/Catalog%20API/createView
 :( . I just fixed that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to