nastra commented on code in PR #12990:
URL: https://github.com/apache/iceberg/pull/12990#discussion_r2076832653
##########
core/src/main/java/org/apache/iceberg/metrics/CommitReport.java:
##########
@@ -27,6 +27,8 @@ public interface CommitReport extends MetricsReport {
String tableName();
+ long timestampMillis();
Review Comment:
we shouldn't be breaking existing APIs, so this should rather be
```
@Value.Default
default long timestampMillis() {
return System.currentTimeMillis();
}
```
That way we don't need to add an exception to RevAPI. See also
https://iceberg.apache.org/contribute/#adding-new-functionality-without-breaking-apis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
