manuzhang commented on code in PR #12990:
URL: https://github.com/apache/iceberg/pull/12990#discussion_r2080809718


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3775,6 +3775,9 @@ components:
       properties:
         table-name:
           type: string
+        timestamp-millis:

Review Comment:
   @flyrain We schedule maintenance tasks by watching on CommitReport. We can 
know when a commit or replace operation happens last time from the new field 
and make a decision accordingly.
   
   > Are we OK with a mismatch with snapshot's timestamp?
   I'm ok with it being `0` (latest snapshot not loaded) or snapshot's 
timestamp. Any other cases I'm missing?



##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3775,6 +3775,9 @@ components:
       properties:
         table-name:
           type: string
+        timestamp-millis:

Review Comment:
   @flyrain We schedule maintenance tasks by watching on CommitReport. We can 
know when a commit or replace operation happens last time from the new field 
and make a decision accordingly.
   
   > Are we OK with a mismatch with snapshot's timestamp?
   
   I'm ok with it being `0` (latest snapshot not loaded) or snapshot's 
timestamp. Any other cases I'm missing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to