rdblue commented on code in PR #12990:
URL: https://github.com/apache/iceberg/pull/12990#discussion_r2087400212
##########
core/src/main/java/org/apache/iceberg/events/CreateSnapshotEvent.java:
##########
@@ -19,21 +19,44 @@
package org.apache.iceberg.events;
import java.util.Map;
+import org.apache.iceberg.Snapshot;
public final class CreateSnapshotEvent {
private final String tableName;
+ private final long timestampMillis;
private final String operation;
private final long snapshotId;
private final long sequenceNumber;
private final Map<String, String> summary;
+ public CreateSnapshotEvent(String tableName, Snapshot snapshot) {
Review Comment:
Does this need to be public? Why update the event at all if the purpose is
to add the timestamp to `CommitReport`? This is an older API that predates the
report, which includes metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
