tomtongue commented on code in PR #12934:
URL: https://github.com/apache/iceberg/pull/12934#discussion_r2068107658
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java:
##########
@@ -99,12 +102,18 @@ public void testCreateNamespace() {
@TestTemplate
public void testDefaultNamespace() {
assumeThat(isHadoopCatalog).as("Hadoop has no default namespace
configured").isFalse();
+ assumeThat(catalogConfig.get(ICEBERG_CATALOG_TYPE))
Review Comment:
Sorry I was confused with this and the other part. I tried to add this part
from Spark 3.4 to Spark 3.5 (I just checked
https://github.com/apache/iceberg/pull/11093 and
https://github.com/apache/iceberg/pull/12934)
However, this assumption is no longer needed in Spark 3.4 as well. So let me
remove this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
