nastra commented on code in PR #12934:
URL: https://github.com/apache/iceberg/pull/12934#discussion_r2068034654


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java:
##########
@@ -99,12 +102,18 @@ public void testCreateNamespace() {
   @TestTemplate
   public void testDefaultNamespace() {
     assumeThat(isHadoopCatalog).as("Hadoop has no default namespace 
configured").isFalse();
+    assumeThat(catalogConfig.get(ICEBERG_CATALOG_TYPE))

Review Comment:
   I'm a little surprised to see this change here. Can you elaborate why this 
is being added here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to