nastra commented on code in PR #12934:
URL: https://github.com/apache/iceberg/pull/12934#discussion_r2068035923
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java:
##########
@@ -187,27 +199,25 @@ public void testListNamespace() {
List<Object[]> namespaces = sql("SHOW NAMESPACES IN %s", catalogName);
- if (isHadoopCatalog) {
- assertThat(namespaces).as("Should have 1 namespace").hasSize(1);
- Set<String> namespaceNames =
- namespaces.stream().map(arr ->
arr[0].toString()).collect(Collectors.toSet());
- assertThat(namespaceNames)
- .as("Should have only db namespace")
- .isEqualTo(ImmutableSet.of("db"));
+ if (isHadoopCatalog
+ ||
catalogConfig.get(ICEBERG_CATALOG_TYPE).equals(ICEBERG_CATALOG_TYPE_REST)) {
Review Comment:
why is this check for REST being added here? we're not testing with REST in
this class, so I'm surprised to see this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
