zeroshade commented on code in PR #408:
URL: https://github.com/apache/iceberg-go/pull/408#discussion_r2066934954
##########
table/arrow_utils.go:
##########
@@ -813,7 +823,26 @@ func (a *arrowProjectionVisitor) Struct(st
iceberg.StructType, structArr arrow.A
}
}
- return retOrPanic(array.NewStructArrayWithFields(fieldArrs, fields))
+ var nullBitmap *memory.Buffer
+ if structArr.NullN() > 0 {
Review Comment:
I don't think that would make it any cleaner really. Unless I'm missing
something, all that would do is force us to duplicate the return line and only
remove one level of braces.
Am I misunderstanding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
