Fokko commented on code in PR #408:
URL: https://github.com/apache/iceberg-go/pull/408#discussion_r2069103524
##########
table/arrow_utils.go:
##########
@@ -417,6 +418,15 @@ func ArrowSchemaToIceberg(sc *arrow.Schema,
downcastNsTimestamp bool, nameMappin
}
}
+func ArrowSchemaToIcebergWithoutIDs(sc *arrow.Schema, downcastNsTimestamp
bool) (*iceberg.Schema, error) {
Review Comment:
What about:
```suggestion
func ArrowSchemaToIcebergWithFreshIDs(sc *arrow.Schema, downcastNsTimestamp
bool) (*iceberg.Schema, error) {
```
Open for other suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]