pdelewski commented on code in PR #408:
URL: https://github.com/apache/iceberg-go/pull/408#discussion_r2066810271
##########
table/arrow_utils.go:
##########
@@ -813,7 +823,26 @@ func (a *arrowProjectionVisitor) Struct(st
iceberg.StructType, structArr arrow.A
}
}
- return retOrPanic(array.NewStructArrayWithFields(fieldArrs, fields))
+ var nullBitmap *memory.Buffer
+ if structArr.NullN() > 0 {
Review Comment:
Would not be cleaner to reverse condition and return
```suggestion
if structArr.NullN() <= 0 {
return retOrPanic(array.NewStructArrayWithFieldsAndNulls(fieldArrs,
fields,
nullBitmap, structArr.NullN(), 0))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]