liurenjie1024 commented on code in PR #1241:
URL: https://github.com/apache/iceberg-rust/pull/1241#discussion_r2065547513
##########
crates/catalog/rest/src/client.rs:
##########
@@ -220,6 +225,39 @@ impl HttpClient {
/// Executes the given `Request` and returns a `Response`.
pub async fn execute(&self, mut request: Request) -> Result<Response> {
request.headers_mut().extend(self.extra_headers.clone());
+
+ if let Some((loader, signer)) = &self.signer {
+ match loader.load().await {
+ Ok(Some(credential)) => {
+ const EMPTY_STRING_SHA256: &str =
+
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855";
+ request.headers_mut().insert(
+ "x-amz-content-sha256",
+ HeaderValue::from_str(EMPTY_STRING_SHA256).unwrap(),
+ );
Review Comment:
I think this behavor should be hidden under `reqsign`. cc @Xuanwo WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
