ananthaksr commented on code in PR #1241:
URL: https://github.com/apache/iceberg-rust/pull/1241#discussion_r2057448422


##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -306,6 +331,13 @@ impl RestCatalog {
             None => None,
         };
 
+        if let Some(warehouse_path) = warehouse_path {
+            if warehouse_path.starts_with("arn:aws:") {
+                let file_io = 
FileIOBuilder::new("s3").with_props(&props).build()?;
+                return Ok(file_io);
+            }

Review Comment:
   Is there a better way to know the rest catalog service e.g. using 
`rest.signing-name`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to