xxchan commented on code in PR #1241: URL: https://github.com/apache/iceberg-rust/pull/1241#discussion_r2057458270
########## Cargo.toml: ########## @@ -93,6 +93,7 @@ port_scanner = "0.1.5" pretty_assertions = "1.4" rand = "0.8.5" regex = "1.10.5" +reqsign = { version = "0.16.3" } Review Comment: reqsign is lightweight, with minimal dependency footprints. And it's already depended by us (transitively via opendal ). So it's good not to introduce new heavy dependencies. @Xuanwo could you share your opinions on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org