manuzhang commented on code in PR #12844:
URL: https://github.com/apache/iceberg/pull/12844#discussion_r2055177800
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteTablePathProcedure.java:
##########
@@ -45,6 +45,8 @@ public class RewriteTablePathProcedure extends BaseProcedure {
ProcedureParameter.optional("end_version", DataTypes.StringType);
private static final ProcedureParameter STAGING_LOCATION_PARAM =
ProcedureParameter.optional("staging_location", DataTypes.StringType);
+ private static final ProcedureParameter SKIP_FILE_LIST_PARAM =
+ ProcedureParameter.optional("skip_file_list", DataTypes.BooleanType);
Review Comment:
I prefer an option like `save_file_list` which defaults to true.
`skip_file_list` doesn't reflect that it's skipping saving file list to a file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
