szehon-ho commented on code in PR #12844:
URL: https://github.com/apache/iceberg/pull/12844#discussion_r2051407254
##########
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##########
@@ -86,6 +86,16 @@ public interface RewriteTablePath extends
Action<RewriteTablePath, RewriteTableP
*/
RewriteTablePath stagingLocation(String stagingLocation);
+ /**
+ * Allows the user to skip saving the file list, determining whether certain
files should be
+ * skipped from being saved.
+ *
+ * @param skipFileList A boolean value indicating whether to skip file
saving. Pass true to skip,
+ * false to not skip.
+ * @return this for method chaining
+ */
+ RewriteTablePath skipFileList(boolean skipFileList);
Review Comment:
we should make a default impl to avoid breaking change
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -303,6 +310,11 @@ private String rebuildMetadata() {
.collect(Collectors.toSet());
rewritePositionDeletes(endMetadata, deleteFiles);
+ // skip file list
+ if (skipFileList) {
+ return "skip-file-list";
Review Comment:
just thinking out loud, would 'null' be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
