slfan1989 commented on code in PR #12844:
URL: https://github.com/apache/iceberg/pull/12844#discussion_r2051418050
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -303,6 +310,11 @@ private String rebuildMetadata() {
.collect(Collectors.toSet());
rewritePositionDeletes(endMetadata, deleteFiles);
+ // skip file list
+ if (skipFileList) {
+ return "skip-file-list";
Review Comment:
I believe using null is fine, but during unit testing, I found that I cannot
use null directly due to a non-null validation. Therefore, I considered using
an empty string or the string 'null' as alternatives. In this version, I opted
for the empty string as a replacement. I'm wondering if this approach is
appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
