nastra commented on code in PR #12808:
URL: https://github.com/apache/iceberg/pull/12808#discussion_r2054346375
##########
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##########
@@ -28,6 +28,9 @@
import org.apache.iceberg.util.PropertyUtil;
public class GCPProperties implements Serializable {
+ /** The GCP project ID. Required. */
+ public static final String PROJECT_ID = "gcp-project";
Review Comment:
why is this and the gcp-location needed in this class for BigQuery? I think
these changes here should be reverted as this class holds stuff for the FileIO
implementation and not for a particular catalog impl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
