morhidi commented on code in PR #12839: URL: https://github.com/apache/iceberg/pull/12839#discussion_r2051301525
########## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java: ########## @@ -173,50 +190,10 @@ public void testTableScanThenIncrementalWithNonEmptyTable() throws Exception { } } - @Test + @TestTemplate Review Comment: @rodmeneses asked `@TestTemplate` hence I tried that, I thought this was some sort of convention in Iceberg, changed now to `@ParameterizedTest` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org