stevenzwu commented on code in PR #12839:
URL: https://github.com/apache/iceberg/pull/12839#discussion_r2051255683
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java:
##########
@@ -173,50 +190,10 @@ public void
testTableScanThenIncrementalWithNonEmptyTable() throws Exception {
}
}
- @Test
+ @TestTemplate
Review Comment:
why not adding the args directly here?
```
@ParameterizedTest
@EnumSource(value = StreamingStartingStrategy.class, names = {
"INCREMENTAL_FROM_LATEST_SNAPSHOT",
"INCREMENTAL_FROM_LATEST_SNAPSHOT_EXCLUSIVE" })
```
##########
docs/docs/flink-configuration.md:
##########
@@ -102,30 +102,30 @@ env.getConfig()
`Read option` has the highest priority, followed by `Flink configuration` and
then `Table property`.
-| Read option | Flink configuration
| Table property | Default |
Description
|
Review Comment:
IDE probably did the auto reformatting. can you disable that and only change
the relevant cell?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
