rodmeneses commented on code in PR #12839:
URL: https://github.com/apache/iceberg/pull/12839#discussion_r2050916538
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/enumerator/ContinuousSplitPlannerImpl.java:
##########
@@ -180,6 +180,15 @@ private ContinuousEnumerationResult
discoverInitialSplits() {
// For TABLE_SCAN_THEN_INCREMENTAL, incremental mode starts exclusive
from the startSnapshot
toPosition =
IcebergEnumeratorPosition.of(startSnapshot.snapshotId(),
startSnapshot.timestampMillis());
+ } else if (scanContext.streamingStartingStrategy()
+ ==
StreamingStartingStrategy.INCREMENTAL_FROM_LATEST_SNAPSHOT_EXCLUSIVE) {
+ splits = Collections.emptyList();
Review Comment:
Could we just initialize splits variable, like
```
List<IcebergSourceSplit> splits = Collections.emptyList()
```
and simplify the code by removing the two assignments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
