Guosmilesmile commented on code in PR #12801:
URL: https://github.com/apache/iceberg/pull/12801#discussion_r2049754850
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java:
##########
@@ -189,6 +189,9 @@ public void initializeState(FunctionInitializationContext
context) throws Except
this.recoveryLock = lockFactory.createRecoveryLock();
if (context.isRestored()) {
shouldRestoreTasks = true;
+ } else {
Review Comment:
If we catch the exception from `lock.unlock();` , the lock from the previous
job in the external system during initialization will not be properly removed,
and the new task will still be unable to execute as expected.
If an exception is thrown, causing the Flink job to restart and re-execute,
it ensures that both the lock and recoveryLock are correctly removed, allowing
the new job to run normally.
Do you think this is appropriate, or have I missed something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
