RussellSpitzer commented on code in PR #12644:
URL: https://github.com/apache/iceberg/pull/12644#discussion_r2045308728
##########
format/spec.md:
##########
@@ -1605,13 +1611,8 @@ All readers are required to read tables with unknown
partition transforms, ignor
Writing v3 metadata:
* Partition Field and Sort Field JSON:
- * `source-ids` was added and is required
- * `source-id` is no longer required and should be omitted; always use
`source-ids` instead
-
-Reading v1 or v2 metadata for v3:
-
-* Partition Field and Sort Field JSON:
- * `source-ids` should default to a single-value list of the value of
`source-id`
+ * `source-ids` was added and is required in the case of multi-argument
transforms.
+ * `source-id` should still be written in the case of single-argument
transforms.
Review Comment:
I thought from the other discussion we are now changing this to source-id is
required for single arg transforms and source-ids is required for multi arg. So
both are optional but are still "must write" language in the spec
* `source-id` must be written in the case of single-argument transforms.
* `source-ids` must be written in the case of a multi-argument transform.
https://github.com/apache/iceberg/pull/12644/files#diff-36347a47c3bf67ea2ef6309ea96201814032d21bb5f162dfae4045508c15588aR1425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
