Fokko commented on code in PR #12644:
URL: https://github.com/apache/iceberg/pull/12644#discussion_r2047560528
##########
format/spec.md:
##########
@@ -1605,13 +1611,8 @@ All readers are required to read tables with unknown
partition transforms, ignor
Writing v3 metadata:
* Partition Field and Sort Field JSON:
- * `source-ids` was added and is required
- * `source-id` is no longer required and should be omitted; always use
`source-ids` instead
-
-Reading v1 or v2 metadata for v3:
-
-* Partition Field and Sort Field JSON:
- * `source-ids` should default to a single-value list of the value of
`source-id`
+ * `source-ids` was added and should be written in case of a multi-argument
transform.
+ * `source-id` should still be written in the case of single-argument
transforms.
Review Comment:
```suggestion
* `source-ids` was added and must be written in the case of a
multi-argument transform.
* `source-id` must be written in the case of single-argument transforms.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
