Fokko commented on code in PR #12644: URL: https://github.com/apache/iceberg/pull/12644#discussion_r2042855103
########## format/spec.md: ########## @@ -1605,13 +1611,8 @@ All readers are required to read tables with unknown partition transforms, ignor Writing v3 metadata: * Partition Field and Sort Field JSON: - * `source-ids` was added and is required - * `source-id` is no longer required and should be omitted; always use `source-ids` instead - -Reading v1 or v2 metadata for v3: - -* Partition Field and Sort Field JSON: - * `source-ids` should default to a single-value list of the value of `source-id` + * `source-ids` was added and is required in the case of multi-argument transforms. + * `source-id` should still be written in the case of single-argument transforms. Review Comment: Iceberg only supports forward compatibility, so V3 readers should be able to read V2, but not the other way around. Still, requiring the table version for serializing the partition-spec does not sound ideal to me. I've changed the PR back to depend on the serialization based on the number of arguments, rather than the table version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
