nastra commented on code in PR #12768:
URL: https://github.com/apache/iceberg/pull/12768#discussion_r2042574912
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -191,6 +192,10 @@ protected boolean supportsEmptyNamespace() {
return false;
}
+ protected String baseTableLocation() {
Review Comment:
```suggestion
protected String baseTableLocation(TableIdentifier identifier) {
```
then we can move the string concatenation of the base
location/namespace/table from all of the other places into this single place,
which would make all calling sites simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
