nastra commented on code in PR #12768: URL: https://github.com/apache/iceberg/pull/12768#discussion_r2039122992
########## core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java: ########## @@ -538,7 +543,7 @@ public void testNamespaceWithDot() { public void testBasicCreateTable() { C catalog = catalog(); - TableIdentifier ident = TableIdentifier.of("ns", "table"); + TableIdentifier ident = TableIdentifier.of("ns", "nstable"); Review Comment: nit: I'd probably then call this `tbl` instead of `nstable` because the `ns` in the same could be a bit misleading. Same for all the other places further below -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org