nastra commented on code in PR #12768:
URL: https://github.com/apache/iceberg/pull/12768#discussion_r2042564996
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -2272,7 +2280,7 @@ public void
testCompleteCreateOrReplaceTransactionCreate() {
if (!overridesRequestedLocation()) {
assertThat(table.location())
.as("Table location should match requested")
- .isEqualTo("file:/tmp/ns/table");
+ .isEqualTo(baseTableLocation() + "/" + TABLE.namespace() + "/" +
TABLE.name());
Review Comment:
thinking more about this, maybe we should add this code into
`baseTableLocation()` and update it to take the TableIdentifier as a
parameter. The calling site would then just be `baseTableLocation(TABLE)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
