RussellSpitzer commented on code in PR #12692:
URL: https://github.com/apache/iceberg/pull/12692#discussion_r2039895111
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -121,32 +113,36 @@ protected RewriteDataFilesSparkAction self() {
@Override
public RewriteDataFilesSparkAction binPack() {
Preconditions.checkArgument(
- rewriter == null, "Must use only one rewriter type (bin-pack, sort,
zorder)");
- this.rewriter = new SparkBinPackDataRewriter(spark(), table);
+ runner == null, "Must use only one rewriter type (bin-pack, sort,
zorder)");
Review Comment:
Follow up, We need to clean up these messages. They probably should say,
"Rewriter type already set to %s" or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
