RussellSpitzer commented on code in PR #12692: URL: https://github.com/apache/iceberg/pull/12692#discussion_r2039897696
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: ########## @@ -101,9 +92,10 @@ public class RewriteDataFilesSparkAction private boolean partialProgressEnabled; private boolean removeDanglingDeletes; private boolean useStartingSequenceNumber; - private RewriteJobOrder rewriteJobOrder; - private FileRewriter<FileScanTask, DataFile> rewriter = null; private boolean caseSensitive; + private BinPackRewriteFilePlanner planner = null; + private FileRewriteRunner<FileGroupInfo, FileScanTask, DataFile, RewriteFileGroup> runner = null; + private boolean shufflingPlanner = false; Review Comment: Why a separate variable here? Can't we just check "if Rewriter extends SortRewriter" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
