steveloughran commented on PR #10233: URL: https://github.com/apache/iceberg/pull/10233#issuecomment-2797407789
> The fallback logic is unnecessary complexity, we should just rely on the bulk delete if available and log/throw if individual deletes fails > There are a lot of comments in the code that are unnecessary or just commentary and don't help with the readability. Happy to cut if that's the project style. > The majority of the docs section is unnecessary. If there are specific values that should be set for S3A we should link to the docs for S3A, but we don't need to go into detail about features/classpath deconfliction/etc. Adding a no-config feature really shouldn't require the docs changes at all. I was trying to include some hints for performance, but can put them in the hadoop docs instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
