talatuyarer opened a new pull request, #12768: URL: https://github.com/apache/iceberg/pull/12768
Hi all, This PR addresses several improvements to the `CatalogTests` class: 1. **`listNamespacesWithEmptyNamespace` Fix:** It corrects a bug where the `listNamespacesWithEmptyNamespace` test doesn't properly check for `supportsEmptyNamespace` on catalogs. This ensures the test is only executed for catalogs that support empty namespaces, preventing potential errors or misleading test results. 2. **Reserved Keyword Avoidance:** The tests were using `TABLE` as a table identifier, which is a reserved keyword in ANSI SQL and various database systems (e.g., [Spark](https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-reserved-words)). This PR renames the identifier to `newtable` to avoid conflicts and improve compatibility with a wider range of catalogs. 3. **Configurable Table Location:** Currently, the `CatalogTests` class hardcodes table locations, preventing catalog implementations from easily overriding this behavior for their specific needs. This PR introduces a mechanism to configure the base table location via the `testTableBaseLocation() ` method, with a default value of `file:/tmp`. This allows sub-classes to adapt the tests to different storage systems and environments. These changes enhance the robustness, compatibility, and flexibility of the `CatalogTests` suite, making it more effective for verifying catalog implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
