pvary commented on code in PR #12427:
URL: https://github.com/apache/iceberg/pull/12427#discussion_r2026902452
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1772,6 +1775,24 @@ public void testNoSchemasOrSpecsToRemove() {
.anyMatch(u -> u instanceof
MetadataUpdate.RemoveSchemas)));
}
+ @TestTemplate
+ public void testCustomWorkerPool() {
+ ExecutorService executor = Executors.newSingleThreadExecutor();
+ // shutdown the executor, cleanExpiredSnapshots should fail
+ executor.shutdownNow();
Review Comment:
Sorry for missing the comment! Went directly to the code, to check, and
haven't seen your response ðŸ˜
What if we create a test very similar to
`TestRewriteManifests.testRewriteManifestsWithScanExecutor` where we check that
the threadpool is used and threads are created from it? It would have an
advantage of failing is someone restores the static initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
