abstractdog commented on code in PR #12427:
URL: https://github.com/apache/iceberg/pull/12427#discussion_r2026705407


##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -153,6 +153,13 @@ public ExpireSnapshots planWith(ExecutorService 
executorService) {
     return this;
   }
 
+  protected ExecutorService planExecutorService() {
+    if (planExecutorService == null) {
+      this.planExecutorService = ThreadPools.getWorkerPool();
+    }

Review Comment:
   ack



##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -197,7 +197,10 @@ protected String targetBranch() {
   }
 
   protected ExecutorService workerPool() {
-    return this.workerPool;
+    if (workerPool == null) {
+      this.workerPool = ThreadPools.getWorkerPool();
+    }
+    return workerPool;

Review Comment:
   ack
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to