abstractdog commented on code in PR #12427:
URL: https://github.com/apache/iceberg/pull/12427#discussion_r2026704750


##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1772,6 +1775,24 @@ public void testNoSchemasOrSpecsToRemove() {
                         .anyMatch(u -> u instanceof 
MetadataUpdate.RemoveSchemas)));
   }
 
+  @TestTemplate
+  public void testCustomWorkerPool() {
+    ExecutorService executor = Executors.newSingleThreadExecutor();
+    // shutdown the executor, cleanExpiredSnapshots should fail
+    executor.shutdownNow();

Review Comment:
   how to mess with the central threadpool? please consider my comment: 
https://github.com/apache/iceberg/pull/12427#issuecomment-2763554614
   
   I mean, let's say I call:
   ```
   ThreadPools.getWorkerPool().shutdown()
   ```
   then what happens to every other tests in the same JVM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to