gaborkaszab commented on code in PR #12194:
URL: https://github.com/apache/iceberg/pull/12194#discussion_r2024437585
##########
core/src/main/java/org/apache/iceberg/rest/BaseHTTPClient.java:
##########
@@ -77,6 +77,18 @@ public <T extends RESTResponse> T get(
return execute(request, responseType, errorHandler, h -> {});
}
+ @Override
+ public <T extends RESTResponse> T get(
Review Comment:
Sorry for the late response.
Do you mean we could move that other `get` function from this class into the
interface? We could have a "responseHeader-less" version in the interface that
calls the version with the responseHeader param using a non-null `h -> {}`
consumer, but I think that would be a behaviour change within the interface.
Calling the "responseHeader-less" version would result in an
`UnsupportedOperationException` from the default implementation of the other
get function in the interface.
With the current approach I tried to follow how [this
PR](https://github.com/apache/iceberg/pull/6578) from @nastra introduced the
same for the `post` methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
