gaborkaszab commented on code in PR #12194:
URL: https://github.com/apache/iceberg/pull/12194#discussion_r2022631100


##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -132,7 +132,7 @@ private HTTPClient(
    * shares the same base uri, mapper, and HTTP client as the parent, thus not 
requiring any
    * additional resource allocation.
    */
-  private HTTPClient(HTTPClient parent, AuthSession authSession) {
+  HTTPClient(HTTPClient parent, AuthSession authSession) {

Review Comment:
   In fact, I'll revert this part (the second commit) from this PR because that 
was a kind of experiment to see how we could test the new interface in 
HTTPClient. Agreed, with @nastra that this isn't the way we'd want to go.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to