zratkai commented on code in PR #12194: URL: https://github.com/apache/iceberg/pull/12194#discussion_r2020947113
########## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ########## @@ -132,7 +132,7 @@ private HTTPClient( * shares the same base uri, mapper, and HTTP client as the parent, thus not requiring any * additional resource allocation. */ - private HTTPClient(HTTPClient parent, AuthSession authSession) { + HTTPClient(HTTPClient parent, AuthSession authSession) { Review Comment: Please use the builder of this class instead of changing the visibility of the constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org