lirui-apache commented on code in PR #12637:
URL: https://github.com/apache/iceberg/pull/12637#discussion_r2013487458
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreExtension.java:
##########
@@ -40,16 +40,10 @@ private HiveMetastoreExtension(String databaseName,
Map<String, String> hiveConf
@Override
public void beforeAll(ExtensionContext extensionContext) throws Exception {
- metastore = new TestHiveMetastore();
- HiveConf hiveConfWithOverrides = new HiveConf(TestHiveMetastore.class);
- if (hiveConfOverride != null) {
- for (Map.Entry<String, String> kv : hiveConfOverride.entrySet()) {
- hiveConfWithOverrides.set(kv.getKey(), kv.getValue());
- }
- }
+ metastore = new TestHiveMetastore(hiveConfOverride);
- metastore.start(hiveConfWithOverrides);
- metastoreClient = new HiveMetaStoreClient(hiveConfWithOverrides);
+ metastore.start(new HiveConf(TestHiveMetastore.class));
+ metastoreClient = new HiveMetaStoreClient(metastore.hiveConf());
Review Comment:
OK I'll try setting the default value to true, if everything is fine, I'll
revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
