pvary commented on code in PR #12637:
URL: https://github.com/apache/iceberg/pull/12637#discussion_r2011741211
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -287,15 +277,25 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
e);
}
- LOG.error(
- "Cannot tell if commit to {}.{} succeeded, attempting to reconnect
and check.",
- database,
- tableName,
- e);
- commitStatus = BaseMetastoreOperations.CommitStatus.UNKNOWN;
- commitStatus =
- BaseMetastoreOperations.CommitStatus.valueOf(
- checkCommitStatus(newMetadataLocation, metadata).name());
+ if (e.getMessage() != null
+ && e.getMessage()
Review Comment:
Could we have a same issue here than with #11576?
If there is a new exception during the `handleConcurrentModification` call,
then the commit status is unset, and the metadata will be removed.
Maybe leave the
```
commitStatus = BaseMetastoreOperations.CommitStatus.UNKNOWN;
```
line before the `if` statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
