pvary commented on code in PR #12637:
URL: https://github.com/apache/iceberg/pull/12637#discussion_r2011862799
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreOperations.java:
##########
@@ -63,6 +64,31 @@ protected CommitStatus checkCommitStatus(
String newMetadataLocation,
Map<String, String> properties,
Supplier<Boolean> commitStatusSupplier) {
+ if (metadataLocationCommitted(
+ tableOrViewName, newMetadataLocation, properties,
commitStatusSupplier)
+ .orElse(false)) {
+ return CommitStatus.SUCCESS;
+ }
+ return CommitStatus.UNKNOWN;
Review Comment:
> Hmm interesting... But I think we don't have to worry about that in our
case, because the double check happens after HMS explicitly returns an
exception, which means it has finished processing right?
There could me multiple HMS instances, and another one might still working
on serving the previous request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
