pvary commented on code in PR #12461: URL: https://github.com/apache/iceberg/pull/12461#discussion_r2010113709
########## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java: ########## @@ -1015,7 +1015,7 @@ public void testSnapshotStatsTableProperties() throws Exception { @Test public void testSetSnapshotSummary() throws Exception { Configuration conf = new Configuration(); - conf.set("iceberg.hive.table-property-max-size", "4000"); + long maxHiveTablePropertySize = 4000; Review Comment: While this comment is minor, and it could be ok to reject it, please consider that the reviewer spends his own time to review your code. Maybe it is not even in his job description, or in his task list to do it, so please be polite as much as possible. Thanks, Peter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org