zratkai commented on code in PR #12461:
URL: https://github.com/apache/iceberg/pull/12461#discussion_r2010066512
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##########
@@ -299,7 +299,10 @@ private void setHmsTableParameters(
BaseMetastoreTableOperations.PREVIOUS_METADATA_LOCATION_PROP,
currentMetadataLocation());
}
- setSchema(metadata.schema(), parameters);
+ HMSTablePropertyHelper.setSchema(
Review Comment:
My helper class is for tables. My intent was not to refactor the whole Hive
part in Iceberg, where we are intending now. I think this would be out of the
scope of this PR, so I suggest to create a separate task for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
