pvary commented on code in PR #12461:
URL: https://github.com/apache/iceberg/pull/12461#discussion_r2012524558
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -73,30 +57,6 @@ public class HiveTableOperations extends
BaseMetastoreTableOperations
private static final String HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES =
"iceberg.hive.metadata-refresh-max-retries";
private static final int HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES_DEFAULT =
2;
- private static final BiMap<String, String> ICEBERG_TO_HMS_TRANSLATION =
- ImmutableBiMap.of(
- // gc.enabled in Iceberg and external.table.purge in Hive are meant
to do the same things
- // but with different names
- GC_ENABLED, "external.table.purge");
-
- /**
- * Provides key translation where necessary between Iceberg and HMS props.
This translation is
- * needed because some properties control the same behaviour but are named
differently in Iceberg
- * and Hive. Therefore changes to these property pairs should be
synchronized.
- *
- * <p>Example: Deleting data files upon DROP TABLE is enabled using
gc.enabled=true in Iceberg and
- * external.table.purge=true in Hive. Hive and Iceberg users are unaware of
each other's control
- * flags, therefore inconsistent behaviour can occur from e.g. a Hive user's
point of view if
- * external.table.purge=true is set on the HMS table but gc.enabled=false is
set on the Iceberg
- * table, resulting in no data file deletion.
- *
- * @param hmsProp The HMS property that should be translated to Iceberg
property
- * @return Iceberg property equivalent to the hmsProp. If no such
translation exists, the original
- * hmsProp is returned
- */
- public static String translateToIcebergProp(String hmsProp) {
Review Comment:
We might not be allowed to remove a public method.
We can deprecate it, and remove it in the next version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
