rdblue commented on code in PR #12512: URL: https://github.com/apache/iceberg/pull/12512#discussion_r2006398578
########## parquet/src/test/java/org/apache/iceberg/parquet/TestVariantReaders.java: ########## @@ -900,6 +1176,31 @@ private static GenericRecord record(GroupType type, Map<String, Object> fields) return record; } + private static <T> List<GenericRecord> elements(Type shreddedType, List<T> elements) { Review Comment: You could also accept a `ValueArray` to transform, rather than a `List` so that you'd be able to generate the data to write based on the expected value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org